Hi all, On Wed, 27 Jun 2018 at 13:50, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 27 June 2018 at 12:12, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > On 27 June 2018 at 12:01, Michael Tretter <m.tret...@pengutronix.de> wrote: > >> On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: > >>> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: > >>> > The example weston.ini file uses source and build > >>> > directory paths. Therefore, it is only useful when > >>> > used on the same system that is used to build Weston. > >>> > > >>> > We can use install paths instead of build/source paths > >>> > to fix this problem. > >>> > > >>> > v2 changes: > >>> > - use $(westondatadir) instead of $(datadir) > >>> > > >>> > Reported-by: Michael Tretter <m.tret...@pengutronix.de> > >>> > Signed-off-by: Emre Ucan <eu...@de.adit-jv.com> > >>> > >>> Reviewed-by: Michael Tretter <m.tret...@pengutronix.de> > >> > >> Some variables that this patch touches have already been removed, but I > >> think it would still make change to rename 'abs_top_builddir' and > >> 'abs_top_srcdir'. Is there anything preventing this patch from being > >> applied? > > > > Is this still required with the recently landed builddir changes by > > Dan/Pekka? > > I'll give it a look after lunch and can offer some feedback, after > > lunch. Gut feeling atm is that this breaks make check. > > My gut feeling and coffee deprived brain were miles off. > Patch is spot on and is > Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
Thanks for the patch and all the review; I've added mine and pushed: cf4113c62..67546bed0 67546bed04a464d18508265976f2a4b673db565c -> master Cheers, Daniel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
