Hi, On Fri, 30 Aug 2019 at 08:45, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 28 Aug 2019 14:49:37 +0000 Simon Ser <cont...@emersion.fr> wrote: > > On Tuesday, August 20, 2019 2:43 PM, Victor Berger <victor.ber...@m4x.org> > > wrote: > > > I can't talk for other projects, but in the case of wayland-rs this > > > kind of corrections to the protocol files is very much welcome. Our > > > scanner makes use of these annotation to generate appropriate APIs, > > > and in this specific case the absence of the annotation makes it > > > generate wrong code. So from wayland-rs point of view this is a > > > bugfix, and thus not in contraction with stability. Especially > > > given wayland-rs has not yet reached stability and is still likely > > > to change, I'll just bump the version number when updating > > > wayland-protocols. > > > > Thanks for your feedback! I'll wait for thoughts from Pekka before > > doing anything, but I'd like to get these fixed too. > > I don't recall hearing much from people with custom code generating > scanners, so until we upset someone and they come to us complaining > about regressions the first time, I am fine with adding these > annotations that do not break the ABI generated by wayland-scanner. > > When we started introducing these new attributes that may "break" the > consumers of code generated by custom scanners, we had a discussion > about this very issue. If I remember right, everyone involved at the > time were happy with the "break" since the benefits will be greater > than the damage in the long run. IIRC Victor was there then, and he > said the same now. > > From my behalf: > > Acked-by: Pekka Paalanen <pekka.paala...@collabora.com> > > Do you need me to land this? > > Since wayland-protocols is still using email workflow, please give all > your Reviewed-by and Acked-by tags explicitly.
With the same rationale - this will only hurt people generating rich bindings, who are the exact people who want it - this is: Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
