Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9668cecef5520dd5a177d2fa0ad7af2a396f0010
      
https://github.com/WebKit/WebKit/commit/9668cecef5520dd5a177d2fa0ad7af2a396f0010
  Author: Tadeu Zagallo <tzaga...@apple.com>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Overload.cpp
    M Source/WebGPU/WGSL/TypeDeclarations.rb

  Log Message:
  -----------
  [WGSL] Overload resolution shouldn't assume we can materialize all variables
https://bugs.webkit.org/show_bug.cgi?id=254588
rdar://problem/107316646

Reviewed by Myles C. Maxfield.

Some overload candidates require explicitly instantiating type variables, and
if no explicit instantiation is given we'll fail to materialize the variable.
In this case, we should reject the overload candidate instead of failing an
assertion and crashing.

* Source/WebGPU/WGSL/Overload.cpp:
(WGSL:: const):
(WGSL::OverloadResolver::considerCandidate):
* Source/WebGPU/WGSL/TypeDeclarations.rb:

Canonical link: https://commits.webkit.org/262323@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to