Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: e535e62130c20c12204f5bf23b56e8a3ebaab788 https://github.com/WebKit/WebKit/commit/e535e62130c20c12204f5bf23b56e8a3ebaab788 Author: Tim Nguyen <n...@apple.com> Date: 2023-04-25 (Tue, 25 Apr 2023)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt M Source/WebCore/platform/calc/CalcExpressionOperation.cpp Log Message: ----------- Cherry-pick 263351@main (a9211716efb3). https://bugs.webkit.org/show_bug.cgi?id=255905 CSS hypot() function sometimes returns the result squared https://bugs.webkit.org/show_bug.cgi?id=255905 rdar://108487071 Reviewed by Tim Horton. In cases where the result is computed by CalcExpressionOperation.cpp, the result ends up being squared, because we're missing a sqrt() operation. The result is correct for cases computed by CSSCalcOperationNode.cpp however, ideally code should be shared to prevent these types of bugs. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/hypot-pow-sqrt-computed-expected.txt: * Source/WebCore/platform/calc/CalcExpressionOperation.cpp: (WebCore::CalcExpressionOperation::evaluate const): Canonical link: https://commits.webkit.org/263351@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes