Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ec22e075245088e425e8c9dfb16efd356e3e2000
https://github.com/WebKit/WebKit/commit/ec22e075245088e425e8c9dfb16efd356e3e2000
Author: Jessica Cheung <jcheun...@apple.com>
Date: 2023-07-17 (Mon, 17 Jul 2023)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/StyledMarkedText.cpp
M Source/WebCore/rendering/TextPaintStyle.cpp
M Source/WebCore/rendering/TextPaintStyle.h
Log Message:
-----------
Highlight logic incorrect for checking author set text color
https://bugs.webkit.org/show_bug.cgi?id=258943
rdar://111706100
Reviewed by Megan Gardner and Aditya Keerthi.
Before logic to determine whether to take a text color of a
StyledMarkedText was to compare to canvasText color.
This causes aproblem if author set color to canvasText or if the color
black was considered as canvasText.
Now, we check if a flag was set indicating the author explicitly
specified a text color.
Updated TestExpectations due to passing test.
Part of priority in spec: https://www.w3.org/TR/css-highlight-api-1/#priorities
* LayoutTests/TestExpectations:
* Source/WebCore/rendering/StyledMarkedText.cpp:
(WebCore::resolveStyleForMarkedText):
(WebCore::coalesceAdjacentWithSameRanges):
* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::computeTextSelectionPaintStyle):
* Source/WebCore/rendering/TextPaintStyle.h:
Canonical link: https://commits.webkit.org/266117@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
