Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f33d80a274e056398ef6b83a60daee41f6ec2ca5
https://github.com/WebKit/WebKit/commit/f33d80a274e056398ef6b83a60daee41f6ec2ca5
Author: Timothy Hatcher <timo...@apple.com>
Date: 2023-11-27 (Mon, 27 Nov 2023)
Changed paths:
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.messages.in
M
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm
M
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm
Log Message:
-----------
Improve Web Extension errors for array types.
https://webkit.org/b/265201
rdar://problem/118691550
Reviewed by Brian Weinstein.
Always include the sub-type expected for the array, and be consistent in the
wording.
Also improve type strings for numbers and JSValues by outputting specific type
strings.
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm:
(WebKit::constructExpectedMessage):
(WebKit::valueToTypeString): Added.
(WebKit::validateSingleObject): Use valueToTypeString.
(WebKit::validateArray): Improve errors.
(WebKit::validateSet): Use valueToTypeString.
* Source/WebKit/UIProcess/Extensions/WebExtensionController.messages.in:
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm:
(WebKit::WebExtensionAPIAction::setIcon):
(WebKit::isValidDimensionKey): Deleted.
*
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm:
(-[_WKWebExtensionWebNavigationURLPredicate
initWithTypeString:value:outErrorMessage:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/271172@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
