Branch: refs/heads/safari-7616.1.24.10-branch Home: https://github.com/WebKit/WebKit Commit: ddc96078ad70e72c268344e41ffec6b2b2382072 https://github.com/WebKit/WebKit/commit/ddc96078ad70e72c268344e41ffec6b2b2382072 Author: Dan Robson <dtr_bugzi...@apple.com> Date: 2023-07-14 (Fri, 14 Jul 2023)
Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.24.10.1 Identifier: 265870.85@safari-7616.1.24.10-branch Commit: 1b27c4bf71fbdb2dfb8c8ee9190e7dc6879eb512 https://github.com/WebKit/WebKit/commit/1b27c4bf71fbdb2dfb8c8ee9190e7dc6879eb512 Author: Dan Glastonbury <d...@apple.com> Date: 2023-07-19 (Wed, 19 Jul 2023) Changed paths: M Source/WebKit/Platform/IPC/Connection.h M Source/WebKit/Platform/IPC/MessageSenderInlines.h M Source/WebKit/Platform/IPC/StreamClientConnection.h M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h Log Message: ----------- Cherry-pick 5d3f12cc83da. rdar://problem/111895837 [IPC] Don't unwrap invalid SendSyncResult replies https://bugs.webkit.org/show_bug.cgi?id=259301 rdar://111895837 Reviewed by Dean Jackson. We have a number of crash reports from an assert firing in std::optional when unwrapping the result of a synchronous IPC call. This assert hints that we have received a result where `succeeded()` returns true, yet we don't have a reply payload in replyArguments. This is a violation of the prerequisites for `ConnectionSendSyncReply`. This issue has been causes by improper handling of `decoder` failure and has been fixed piecemeal, for example in https://bugs.webkit.org/show_bug.cgi?id=259006. This change extends the succeeded check to include checking for non-none replyArguments to avoid asserting when using `if (sendResult.succeeded()) { ... = sendResult.reply(); }` pattern. As an extra level of protection, the new ConnecttionSendSyncResult will set error to Error::Unspecified if passed replyArguments that are none. * Source/WebKit/Platform/IPC/Connection.h: (IPC::ConnectionSendSyncResult::ConnectionSendSyncResult): (IPC::ConnectionSendSyncResult::succeeded const): (IPC::Connection::sendSync): * Source/WebKit/Platform/IPC/MessageSenderInlines.h: (IPC::MessageSender::sendSync): * Source/WebKit/Platform/IPC/StreamClientConnection.h: (IPC::StreamClientConnection::sendSync): (IPC::StreamClientConnection::trySendSyncStream): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::sendSync): Canonical link: https://commits.webkit.org/266147@main Commit: 6b8164118c886918336236087be28ec5692d3233 https://github.com/WebKit/WebKit/commit/6b8164118c886918336236087be28ec5692d3233 Author: Russell Epstein <repst...@apple.com> Date: 2023-07-19 (Wed, 19 Jul 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.24.10.2 Identifier: 265870.87@safari-7616.1.24.10-branch Compare: https://github.com/WebKit/WebKit/compare/ddc96078ad70%5E...6b8164118c88 _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes