alaa_wmde added a comment.

  @Hanna_Petruschat_WMDE
  
  Regarding the AC:
  
  > [ ] the background colors have a negative padding of 16px to the left
  
  
  
  - this negative padding seem to be needed, esp. with that specific value, for 
a certain skin. Where it might not be needed, or value should be different for 
other skins.
  - the background is not being expanded on wider view 
<https://www.figma.com/file/g86G4bYOcUoIPwEbN041nq/180607_Termbox-Mobile-Sprint?node-id=1591%3A0>
 (supposedly because the space from the edge is bigger and we did not want to 
expand it too much till the edge, like done for the mobile version)
  
  Until we figure out whether/how we want to achieve this, esp. in a way that 
is skin-agnostic, would you be okay if we leave this requirement out of this 
story to deliver the rest without waiting on this one?

TASK DETAIL
  https://phabricator.wikimedia.org/T223452

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, Hanna_Petruschat_WMDE, Pablo-WMDE, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to