Lectrician1 added a comment.
@karapayneWMDE FYI the Growth team may not find the implementation I made to be be suitable as it makes the page names inside of notifications links instead of strings. In the past, Echo used to have links for page names <https://www.mediawiki.org/wiki/Topic:X93w9kyu89dw9r93> in notifications but that was removed. I personally find benefits <https://phabricator.wikimedia.org/T324848> though to having links instead of strings though. If you need me to create an implementation that does output strings instead of links, I can create a new MediaWiki hook for when the the string title of a page is retrieved that Wikibase can then modify to output the label of the entity page instead. I just need to know if that's what you need me to do - or some other implementation you come up with. Also, tests have not been added on the Echo change yet as I don't know if this patch is good, but I'll add them when you let me know it's okay. TASK DETAIL https://phabricator.wikimedia.org/T116762 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lectrician1 Cc: karapayneWMDE, Celenduin, Michael, kostajh, Lectrician1, Ainali, JTannerWMF, Catrope, MMiller_WMF, Aleksey_WMDE, WMDE-leszek, ChristianKl, Daniel_Mietchen, Sjoerddebruin, Jdforrester-WMF, Legoktm, matej_suchanek, Luke081515, Lydia_Pintscher, Addshore, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Taiwania_Justo, Neuronton, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
