| Bawolff added a comment. |
In T149082#2968137, @Addshore wrote:In T149082#2966632, @Bawolff wrote:
- I assume this is not using the LinkUpdates related hooks because it only wants to deal with new pages not edits (?) However it seems that this still triggers on all edits. Perhaps it should look at the EDIT_NEW flag in the onPageSaveComplete hook to avoid some unnecessary database interaction.
Cognate needs to know when pages are edited to determine if the redirect state has changed:
- redirect -> regular page = needs to be added to the db
- regular page -> redirect = needs to be removed from the db
If I had both the new and the last content then I would be able to check the redirect state of each and only act where needed here. I'll have a further look.
Oh. This makes sense to me now. When i was first looking at it I didnt realize it needed to do that
TASK DETAIL
EMAIL PREFERENCES
To: Bawolff
Cc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm
Cc: gerritbot, Bawolff, daniel, Aklapper, Addshore, Lydia_Pintscher, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Andrew-WMDE, dpatrick, Izno, Luke081515, Wikidata-bugs, aude, JanZerebecki, Darkdadaah, csteipp, Mbch331, Jay8g, Legoktm
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
