| Bawolff moved this task from Scheduled to Done on the Security-Reviews board. Bawolff closed this task as "Resolved". Bawolff claimed this task. Bawolff added a comment. |
Sorry for the delay in reviewing this one.
Security review passed. There's not much to say. Most of the interface work is done by Wikibase, so there's not very much attack surface in this extension. Two minor comments unrelated to security that I have:
- It doesn't matter, but it is kind of odd there is a special page alias file when there's no special pages.
- The discussion tab on a MediaInfo page leads the the media info id number in the main namespace. This seems wrong. I would expect either there be no discussion tab in the media info view, or the media info namespace be similar to the annotations extension where it appears as if its attached to the file namespace and the talk tab goes back to the File_talk namespace.
TASK DETAIL
EMAIL PREFERENCES
To: Bawolff
Cc: Bawolff, dpatrick, Ricordisamoa, Aklapper, Lydia_Pintscher, QZanden, Acer, Izno, Luke081515, Wikidata-bugs, Base, matthiasmullie, aude, Deskana, JanZerebecki, Fabrice_Florin, csteipp, Mbch331, Jay8g, Legoktm, Tgr
Cc: Bawolff, dpatrick, Ricordisamoa, Aklapper, Lydia_Pintscher, QZanden, Acer, Izno, Luke081515, Wikidata-bugs, Base, matthiasmullie, aude, Deskana, JanZerebecki, Fabrice_Florin, csteipp, Mbch331, Jay8g, Legoktm, Tgr
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
