> On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.per...@citrix.com> wrote: > > This patch fix ".ocamldep.make" rule by always spelling the variable > $(OCAML_TOPLEVEL). > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > --- > > Notes: > v2: > - new patch > > tools/ocaml/libs/eventchn/Makefile | 8 ++++---- > tools/ocaml/libs/mmap/Makefile | 8 ++++---- > tools/ocaml/libs/xb/Makefile | 8 ++++---- > tools/ocaml/libs/xc/Makefile | 8 ++++---- > tools/ocaml/libs/xentoollog/Makefile | 8 ++++---- > tools/ocaml/libs/xl/Makefile | 8 ++++---- > tools/ocaml/libs/xs/Makefile | 8 ++++---- > tools/ocaml/Makefile.rules | 2 +-
Acked-by: Christian Lindig <christian.lin...@citrix.com> I am fine with this but in general think that the OCaml part should be built using Dune (but invoked from Make), which is now the standard tool to build OCaml projects and is simple, fast, and accurate. Edwin maintains such a build for all development work on the OCaml side but it is not upstreamed. — C
