On 8 Nov 2022, at 15:34, Edwin Török <edvin.to...@citrix.com<mailto:edvin.to...@citrix.com>> wrote:
If we are out of memory then strdup may return NULL, and passing NULL to syslog may cause a crash. Avoid this by using `caml_stat_strdup` which will raise an OCaml out of memory exception instead. This then needs to be paired with caml_stat_free. Signed-off-by: Edwin Török <edvin.to...@citrix.com<mailto:edvin.to...@citrix.com>> --- Reason for inclusion in 4.17: - fixes a bug in out of memory situations Changes since v2: - new in v3 --- tools/ocaml/xenstored/syslog_stubs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) Acked-by: Christian Lindig <christian.lin...@citrix.com<mailto:christian.lin...@citrix.com>>
