> On 24 Mar 2023, at 20:25, Andrew Cooper <andrew.coop...@citrix.com> wrote:
>
> Strings in Ocaml carry their own length. Absolutely nothing good can come
> from having caml_string_length(data) be different to len.
>
> Use the appropriate accessor, String_val(), but retain the workaround for the
> Ocaml -safe-string constness bug in the same way as we've done elsewhere in
> Xen.
>
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> CC: Christian Lindig <christian.lin...@citrix.com>
> CC: David Scott <d...@recoil.org>
> CC: Edwin Török <edwin.to...@cloud.com>
> CC: Rob Hoes <rob.h...@citrix.com>
> ---
> tools/ocaml/libs/mmap/xenmmap.ml | 4 ++--
> tools/ocaml/libs/mmap/xenmmap.mli | 2 +-
> tools/ocaml/libs/mmap/xenmmap_stubs.c | 11 +++++------
> 3 files changed, 8 insertions(+), 9 deletions(-)
Acked-by: Christian Lindig <christian.lin...@cloud.com>
