Re: [PATCH v3 14/46] hw/mips/loongson3_virt: use pci_init_nic_devices()

[Thomas Huth]

On 08/01/2024 21.26, David Woodhouse wrote:

From: David Woodhouse <d...@amazon.co.uk>

Signed-off-by: David Woodhouse <d...@amazon.co.uk>
---
  hw/mips/loongson3_virt.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
index 33eae01eca..caedde2df0 100644
--- a/hw/mips/loongson3_virt.c
+++ b/hw/mips/loongson3_virt.c
@@ -451,9 +451,7 @@ static inline void loongson3_virt_devices_init(MachineState 
*machine,
          usb_create_simple(usb_bus_find(-1), "usb-tablet");
      }

- for (i = 0; i < nb_nics; i++) {

-        pci_nic_init_nofail(&nd_table[i], pci_bus, mc->default_nic, NULL);
-    }
+    pci_init_nic_devices(pci_bus, mc->default_nic);
  }

static void mips_loongson3_virt_init(MachineState *machine)

Reviewed-by: Thomas Huth <th...@redhat.com>