On 05/02/2024 1:32 pm, Jan Beulich wrote: > The type not being used in do_bug_frame() is suspicious. Apparently > that's solely because the type uses a pointer-to-const parameter, > when so far run_in_exception_handler() wanted functions taking pointer- > to-non-const. Expand use of const, in turn requiring common code's > do_bug_frame() as well as [gs]et_irq_regs() to also gain const. This > then brings the former function also closer to the common one, with > Arm's use of vaddr_t remaining as a difference. > > While there also replace the bogus use of hard tabs in [gs]et_irq_regs() > (I clearly didn't mean to put it in like this).
I meant to query that at the time and clearly forgot to. > Signed-off-by: Jan Beulich <jbeul...@suse.com> I'm still confident we can get rid of the fake frame in the serial drivers, but this is an improvement nonetheless. Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> I'll rebase my work over this. It's going to collide horribly. ~Andrew
