On 06.02.2024 02:20, George Dunlap wrote: > @@ -144,7 +144,7 @@ static bool __init hap_supported(struct > hvm_function_table *fns) > > if ( !opt_hap_enabled ) > { > - fns->hap_supported = 0; > + fns->caps.hap = 0;
As you touch such, would you mind switching to true/false instead of 1/0 at this occasion? > @@ -3000,7 +3000,7 @@ const struct hvm_function_table * __init start_vmx(void) > vmx_function_table.update_eoi_exit_bitmap = > vmx_update_eoi_exit_bitmap; > vmx_function_table.process_isr = vmx_process_isr; > vmx_function_table.handle_eoi = vmx_handle_eoi; > - vmx_function_table.virtual_intr_delivery_enabled = true; > + vmx_function_table.caps.virtual_intr_delivery = true; I'm unsure about this one - it had "enabled" in its name for a good reason. Then again its (somewhat more involved) derivation from other capability bits (and a command line option) isn't fundamentally different from that of, say, hap_supported. Hence I guess with the other item taken care of Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan