On 05.04.2024 14:11, Fouad Hilly wrote: > --- a/tools/libs/ctrl/xc_misc.c > +++ b/tools/libs/ctrl/xc_misc.c > @@ -203,7 +203,7 @@ int xc_physinfo(xc_interface *xch, > return 0; > } > > -int xc_microcode_update(xc_interface *xch, const void *buf, size_t len) > +int xc_microcode_update(xc_interface *xch, const void *buf, size_t len, > uint32_t flags)
I don't think uint32_t needs using here; unsigned int will be just fine. The line also looks a little long. > @@ -215,7 +215,15 @@ int xc_microcode_update(xc_interface *xch, const void > *buf, size_t len) > > memcpy(uc, buf, len); > > - platform_op.cmd = XENPF_microcode_update; > + if ( flags > XENPF_UCODE_FLAG_FORCE_NOT_SET ) I was wondering about the purpose of XENPF_UCODE_FLAG_FORCE_NOT_SET. I don't think this constant is needed: Just like with any flags, simply using 0 when none are set is fine both at the producing and consuming sides. > @@ -120,12 +125,17 @@ int main(int argc, char *argv[]) > goto ext_err; > show_curr_cpu(stdout); > exit(EXIT_SUCCESS); > + case 'f': > + ucode_flag = XENPF_UCODE_FLAG_FORCE_SET; Nit: Bad indentation. Jan
