Hi Andrew, On 10/04/2024 20:42, Andrew Cooper wrote: > > > The start/stop1/etc linkage scheme predates struct virtual_region, and as > setup_virtual_regions() shows, it's awkward to express in the new scheme. > > Change the linker to provide explicit start/stop symbols for each bugframe > type, and change virtual_region to have a stop pointer rather than a count. > > This marginly simplifies both do_bug_frame()s and prepare_payload(), but it NIT: s/marginly/marginally
> massively simplifies setup_virtual_regions() by allowing the compiler to > initialise the .frame[] array at build time. > > virtual_region.c is the only user of the linker symbols, and this is unlikely > to change given the purpose of struct virtual_region, so move their externs > out of bug.h > > No functional change. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Ross Lagerwall <ross.lagerw...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> For Arm: Acked-by: Michal Orzel <michal.or...@amd.com> ~Michal
