On 23.04.2024 17:12, Nicola Vetrini wrote: > --- a/xen/drivers/char/omap-uart.c > +++ b/xen/drivers/char/omap-uart.c > @@ -48,8 +48,9 @@ > /* System configuration register */ > #define UART_OMAP_SYSC_DEF_CONF 0x0d /* autoidle mode, wakeup is enabled > */ > > -#define omap_read(uart, off) readl((uart)->regs + (off<<REG_SHIFT)) > -#define omap_write(uart, off, val) writel((val), (uart)->regs + > (off<<REG_SHIFT)) > +#define omap_read(uart, off) readl((uart)->regs + ((off) << REG_SHIFT)) > +#define omap_write(uart, off, val) writel((val), (uart)->regs + \
Would have been nice to drop the excess parentheses at the same time. Jan
