On 26.04.2024 01:13, Stefano Stabellini wrote: > On Tue, 16 Apr 2024, Edgar E. Iglesias wrote: >> From: "Edgar E. Iglesias" <edgar.igles...@amd.com> >> >> Use the generic xen/linkage.h macros when and add missing > ^ when what? > >> code symbol annotations. >> >> Signed-off-by: Edgar E. Iglesias <edgar.igles...@amd.com> > > I am looking at the implementation of FUNC and as far as I can tell > there is no change compared to ENTRY. So from that point of view we are > good. I wonder if we should keep using "ENTRY" because it is nice to > mark explicitely the entry points as such but at the same time I am also > OK with this. I'll let the other ARM maintainers decide.
Just to mention it: ENTRY should go away (and hence why PPC and RISC-V had it dropped already, while x86 has patches pending to reduce its scope enough), not the least to finally allow the oddity near the top of xen.lds.S to go away. Jan
