On 24/04/24 14:38, Jan Beulich wrote:
On 24.04.2024 14:23, Federico Serafini wrote:
Update ECLAIR configuration to take into account the deviations
agreed during MISRA meetings.
Amend an existing entry of Rule 14.4 in deviations.rst:
it is not a project-wide deviation.
Who / how is it not? ->is_dying is a globally visible struct field.
Given a project and a guideline, we use the term "project-wide
deviation" when all violations of the given guideline are deviated.
--- a/docs/misra/deviations.rst
+++ b/docs/misra/deviations.rst
@@ -294,7 +294,13 @@ Deviations related to MISRA C:2012 Rules:
- The XEN team relies on the fact that the enum is_dying has the
constant with assigned value 0 act as false and the other ones as true,
therefore have the same behavior of a boolean.
- - Project-wide deviation; tagged as `deliberate` for ECLAIR.
+ - Tagged as `deliberate` for ECLAIR.
+
+ * - R14.4
+ - A controlling expression of 'if' and iteration statements having
+ integer, character or pointer type has a semantics that is well-known to
+ all Xen developers.
+ - Tagged as `deliberate` for ECLAIR.
I'm inclined to suggest that this more generic deviation be inserted ahead
of the more specific ->is_dying one.
Ok.
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
