Hi, On 2024/5/10 15:48, Juergen Gross wrote: > On 19.04.24 05:36, Jiqian Chen wrote: >> In PVH dom0, the gsis don't get registered, but the gsi of >> a passthrough device must be configured for it to be able to be >> mapped into a domU. >> >> When assign a device to passthrough, proactively setup the gsi >> of the device during that process. >> >> Co-developed-by: Huang Rui <ray.hu...@amd.com> >> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> >> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > > This patch is breaking the build. > > On Arm I get: > > In file included from > /home/gross/korg/src/drivers/xen/xen-pciback/pci_stub.c:23:0: > /home/gross/korg/src/include/xen/acpi.h: In function > 'xen_acpi_sleep_register': > /home/gross/korg/src/include/xen/acpi.h:67:3: error: 'acpi_suspend_lowlevel' > undeclared (first use in this function); did you mean > 'xen_acpi_suspend_lowlevel'? > acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel; > ^~~~~~~~~~~~~~~~~~~~~ > xen_acpi_suspend_lowlevel > /home/gross/korg/src/include/xen/acpi.h:67:3: note: each undeclared > identifier is reported only once for each function it appears in > make[6]: *** [/home/gross/korg/src/scripts/Makefile.build:244: > drivers/xen/xen-pciback/pci_stub.o] Error 1 > make[5]: *** [/home/gross/korg/src/scripts/Makefile.build:485: > drivers/xen/xen-pciback] Error 2 > make[4]: *** [/home/gross/korg/src/scripts/Makefile.build:485: drivers/xen] > Error 2 Thanks for testing on Arm, it seems I should use macro "CONFIG_X86" to isolate the modifications to this file.
> > Additionally I'm seeing this warning on x86_64: > > /home/gross/korg/src/arch/x86/xen/enlighten_pvh.c:97:5: warning: no previous > prototype for ‘xen_pvh_passthrough_gsi’ [-Wmissing-prototypes] > int xen_pvh_passthrough_gsi(struct pci_dev *dev) I think I need to add " #include <xen/acpi.h> " in file enlighten_pvh.c. > > > Juergen -- Best regards, Jiqian Chen.
