On 06.05.2024 17:53, Carlo Nonato wrote: > Hi Jan, > > On Mon, May 6, 2024 at 2:01 PM Jan Beulich <jbeul...@suse.com> wrote: >> >> On 02.05.2024 18:55, Carlo Nonato wrote: >>> Add a command line parameter to allow the user to set the coloring >>> configuration for Dom0. >>> A common configuration syntax for cache colors is introduced and >>> documented. >>> Take the opportunity to also add: >>> - default configuration notion. >>> - function to check well-formed configurations. >>> >>> Direct mapping Dom0 isn't possible when coloring is enabled, so >>> CDF_directmap flag is removed when creating it. >>> >>> Based on original work from: Luca Miccio <lucmic...@gmail.com> >>> >>> Signed-off-by: Carlo Nonato <carlo.non...@minervasys.tech> >>> Signed-off-by: Marco Solieri <marco.soli...@minervasys.tech> >> >> Reviewed-by: Jan Beulich <jbeul...@suse.com> >> albeit ... >> >>> v8: >>> - added bound check on dom0_num_colors >>> - default colors array set just once >>> v7: >>> - parse_color_config() doesn't accept leading/trailing commas anymore >>> - removed alloc_colors() helper >>> v6: >>> - moved domain_llc_coloring_free() in this patch >> >> ... I'm having trouble seeing why this was done: Dom0 isn't ever cleaned up >> after, is it? > > domain_destroy() is never called for dom0, right?
Indeed, with perhaps the exception of late hwdom (assuming that feature hasn't bit-rotted). Jan > If so, yes this is wrongly placed here. > > Thanks. > >> Jan
