Hi All,
This is v7 series to support passthrough on Xen when dom0 is PVH.
v6->v7 change:
* the first patch of v6 was already merged into branch linux_next.
* patch#1: is the patch#2 of v6. move the implementation of function
xen_acpi_get_gsi_info to
file drivers/xen/acpi.c, that modification is more convenient for
the subsequent
patch to obtain gsi.
* patch#2: is the patch#3 of v6. add a new parameter "gsi" to struct
pcistub_device and set
gsi when pcistub initialize device. Then when userspace wants to get
gsi by passing
sbdf, we can return that gsi.
Best regards,
Jiqian Chen
v5->v6 change:
* patch#3: change to add a new syscall to translate irq to gsi, instead adding
a new gsi sysfs.
v4->v5 changes:
* patch#1: Add Reviewed-by Stefano
* patch#2: Add Reviewed-by Stefano
* patch#3: No changes
v3->v4 changes:
* patch#1: change the comment of PHYSDEVOP_pci_device_state_reset; use a new
function
pcistub_reset_device_state to wrap __pci_reset_function_locked and
xen_reset_device_state,
and call pcistub_reset_device_state in pci_stub.c
* patch#2: remove map_pirq from xen_pvh_passthrough_gsi
v2->v3 changes:
* patch#1: add condition to limit do xen_reset_device_state for no-pv domain in
pcistub_init_device.
* patch#2: Abandoning previous implementations that call unmask_irq. To setup
gsi and map pirq for
passthrough device in pcistub_init_device.
* patch#3: Abandoning previous implementations that adds new syscall to get gsi
from irq. To add a new
sysfs for gsi, then userspace can get gsi number from sysfs.
Below is the description of v2 cover letter:
This series of patches are the v2 of the implementation of passthrough when
dom0 is PVH on Xen.
We sent the v1 to upstream before, but the v1 had so many problems and we got
lots of suggestions.
I will introduce all issues that these patches try to fix and the differences
between v1 and v2.
Issues we encountered:
1. pci_stub failed to write bar for a passthrough device.
Problem: when we run \u201csudo xl pci-assignable-add <sbdf>\u201d to assign a
device, pci_stub will
call \u201cpcistub_init_device() -> pci_restore_state() ->
pci_restore_config_space() ->
pci_restore_config_space_range() -> pci_restore_config_dword() ->
pci_write_config_dword(), the pci
config write will trigger an io interrupt to bar_write() in the xen, but the
bar->enabled was set before,
the write is not allowed now, and then when bar->Qemu config the passthrough
device in xen_pt_realize(),
it gets invalid bar values.
Reason: the reason is that we don't tell vPCI that the device has been reset,
so the current cached state
in pdev->vpci is all out of date and is different from the real device state.
Solution: to solve this problem, the first patch of kernel(xen/pci: Add
xen_reset_device_state
function) and the fist patch of xen(xen/vpci: Clear all vpci status of device)
add a new hypercall to
reset the state stored in vPCI when the state of real device has changed.
Thank Roger for the suggestion of this v2, and it is different from v1
(https://lore.kernel.org/xen-devel/20230312075455.450187-3-ray.hu...@amd.com/),
v1 simply allow domU to
write pci bar, it does not comply with the design principles of vPCI.
2. failed to do PHYSDEVOP_map_pirq when dom0 is PVH
Problem: HVM domU will do PHYSDEVOP_map_pirq for a passthrough device by using
gsi. See
xen_pt_realize->xc_physdev_map_pirq and pci_add_dm_done->xc_physdev_map_pirq.
Then xc_physdev_map_pirq
will call into Xen, but in hvm_physdev_op(), PHYSDEVOP_map_pirq is not allowed.
Reason: In hvm_physdev_op(), the variable "currd" is PVH dom0 and PVH has no
X86_EMU_USE_PIRQ flag, it
will fail at has_pirq check.
Solution: I think we may need to allow PHYSDEVOP_map_pirq when "currd" is dom0
(at present dom0 is PVH).
The second patch of xen(x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0) allow
PVH dom0 do
PHYSDEVOP_map_pirq. This v2 patch is better than v1, v1 simply remove the
has_pirq check
(xen
https://lore.kernel.org/xen-devel/20230312075455.450187-4-ray.hu...@amd.com/).
3. the gsi of a passthrough device doesn't be unmasked
3.1 failed to check the permission of pirq
3.2 the gsi of passthrough device was not registered in PVH dom0
Problem:
3.1 callback function pci_add_dm_done() will be called when qemu config a
passthrough device for domU.
This function will call xc_domain_irq_permission()-> pirq_access_permitted() to
check if the gsi has
corresponding mappings in dom0. But it didn\u2019t, so failed. See
XEN_DOMCTL_irq_permission->pirq_access_permitted, "current" is PVH dom0 and it
return irq is 0.
3.2 it's possible for a gsi (iow: vIO-APIC pin) to never get registered on PVH
dom0, because the
devices of PVH are using MSI(-X) interrupts. However, the IO-APIC pin must be
configured for it to be
able to be mapped into a domU.
Reason: After searching codes, I find "map_pirq" and "register_gsi" will be
done in function
vioapic_write_redirent->vioapic_hwdom_map_gsi when the gsi(aka ioapic's pin) is
unmasked in PVH dom0.
So the two problems can be concluded to that the gsi of a passthrough device
doesn't be unmasked.
Solution: to solve these problems, the second patch of kernel(xen/pvh: Unmask
irq for passthrough device
in PVH dom0) call the unmask_irq() when we assign a device to be passthrough.
So that passthrough devices
can have the mapping of gsi on PVH dom0 and gsi can be registered. This v2
patch is different from the
v1( kernel
https://lore.kernel.org/xen-devel/20230312120157.452859-5-ray.hu...@amd.com/,
kernel
https://lore.kernel.org/xen-devel/20230312120157.452859-5-ray.hu...@amd.com/ and
xen
https://lore.kernel.org/xen-devel/20230312075455.450187-5-ray.hu...@amd.com/),
v1 performed "map_pirq" and "register_gsi" on all pci devices on PVH dom0,
which is unnecessary and may
cause multiple registration.
4. failed to map pirq for gsi
Problem: qemu will call xc_physdev_map_pirq() to map a passthrough
device\u2019s gsi to pirq in function
xen_pt_realize(). But failed.
Reason: According to the implement of xc_physdev_map_pirq(), it needs gsi
instead of irq, but qemu pass
irq to it and treat irq as gsi, it is got from file
/sys/bus/pci/devices/xxxx:xx:xx.x/irq in function
xen_host_pci_device_get(). But actually the gsi number is not equal with irq.
On PVH dom0, when it
allocates irq for a gsi in function acpi_register_gsi_ioapic(), allocation is
dynamic, and follow the
principle of applying first, distributing first. And if you debug the kernel
codes(see
function __irq_alloc_descs), you will find the irq number is allocated from
small to large by order, but
the applying gsi number is not, gsi 38 may come before gsi 28, that causes gsi
38 get a smaller irq number
than gsi 28, and then gsi != irq.
Solution: we can record the relation between gsi and irq, then when
userspace(qemu) want to use gsi, we
can do a translation. The third patch of kernel(xen/privcmd: Add new syscall to
get gsi from irq) records
all the relations in acpi_register_gsi_xen_pvh() when dom0 initialize pci
devices, and provide a syscall
for userspace to get the gsi from irq. The third patch of xen(tools: Add new
function to get gsi from irq)
add a new function xc_physdev_gsi_from_irq() to call the new syscall added on
kernel side.
And then userspace can use that function to get gsi. Then xc_physdev_map_pirq()
will success. This v2 patch
is the same as v1( kernel
https://lore.kernel.org/xen-devel/20230312120157.452859-6-ray.hu...@amd.com/ and
xen
https://lore.kernel.org/xen-devel/20230312075455.450187-6-ray.hu...@amd.com/)
About the v2 patch of qemu, just change an included head file, other are
similar to the v1 (
qemu
https://lore.kernel.org/xen-devel/20230312092244.451465-19-ray.hu...@amd.com/),
just call
xc_physdev_gsi_from_irq() to get gsi from irq.
Jiqian Chen (2):
xen/pvh: Setup gsi for passthrough device
xen/privcmd: Add new syscall to get gsi from dev
arch/x86/xen/enlighten_pvh.c | 21 +++++++++++
drivers/acpi/pci_irq.c | 2 +-
drivers/xen/acpi.c | 50 +++++++++++++++++++++++++
drivers/xen/privcmd.c | 28 ++++++++++++++
drivers/xen/xen-pciback/pci_stub.c | 59 ++++++++++++++++++++++++++++--
include/linux/acpi.h | 1 +
include/uapi/xen/privcmd.h | 7 ++++
include/xen/acpi.h | 12 ++++++
8 files changed, 176 insertions(+), 4 deletions(-)
--
2.34.1
