Hi xmame people,
Here is a small patch that replace a call to a DGA1 function with the
matching DGA2 version.
diff -ru xmame-0.57.1/src/unix/video-drivers/xf86_dga2.c
xmame-0.57.1-f/src/unix/video-drivers/xf86_dga2.c
--- xmame-0.57.1/src/unix/video-drivers/xf86_dga2.c Wed Jan 2 03:45:56 2002
+++ xmame-0.57.1-f/src/unix/video-drivers/xf86_dga2.c Fri Jan 25 22:13:38 2002
@@ -524,7 +524,7 @@
if(xf86_dga_fix_viewport)
{
- XF86DGASetViewPort(display,xf86ctx.screen,0,0);
+ XDGASetViewport(display,xf86ctx.screen, 0, 0, 0);
xf86_dga_fix_viewport = 0;
}
Note that the DGA2 version takes an additional flag. A quick search will
show that this function is also called from xf86_dga2_create_display()
at line 405 :
XDGASetViewport(display,xf86ctx.screen,0,0,XDGAFlipImmediate);
I don't understand what the author wanted to achieve here. I believe we
can put "0" here too :
- we don't know if the X server support that flag and according to the
documentation (README.DGA file) -> "Values other than the supported
values advertised in the mode's viewportFlags field will result in
hardware-specific default behavior."
So, if we really wanted to specify a particular value, we should pass
xf86ctx.modes->viewportFlags instead of XDGAFlipImmediate. Right ?
- we are in an initialization routine, I suppose we don't care when the
location adjustement will be done, am I missing something here ?
Fernand
_______________________________________________
Xmame mailing list
[EMAIL PROTECTED]
http://toybox.twisted.org.uk/mailman/listinfo/xmame
