[
https://issues.apache.org/jira/browse/YARN-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046466#comment-17046466
]
Peter Bacsko edited comment on YARN-10167 at 2/27/20 11:01 AM:
---------------------------------------------------------------
[~sunilg] it's way too complicated. IMO we don't need to contact the RM for
validation. As [~leftnoteasy] said, the cluster might be down.
Note that the converter itself already starts an FS instance inside to parse
and load the allocation file. We can do the same thing with CS. Just load the
converted config along with the delta {{yarn-site.xml}} (which essentially
means that we merge the original site + the delta) and let's see if it can
start. If not, we might have a problem and the configuration needs adjustments.
Otherwise it's good (at least from a syntactic perspective).
was (Author: pbacsko):
[~sunilg] I think it's way too complicated. I don't think that we need to
contact the RM for validation. As [~leftnoteasy] said, the cluster might be
down.
Note that the converter itself already starts an FS instance inside to parse
and load the allocation file. We can do the same thing with CS. Just load the
converted config along with the delta {{yarn-site.xml}} (which essentially
means that we merge the original site + the delta) and let's see if it can
start. If not, we might have a problem and the configuration needs adjustments.
Otherwise it's good (at least from a syntactic perspective).
> FS-CS Converter: Need validate c-s.xml after converting
> -------------------------------------------------------
>
> Key: YARN-10167
> URL: https://issues.apache.org/jira/browse/YARN-10167
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Priority: Major
> Labels: fs2cs, newbie
>
> Currently we just generated c-s.xml, but we didn't validate that. To make
> sure the c-s.xml is correct after conversion, it's better to initialize the
> CS scheduler using configs.
> Also, in the test, we should try to leverage MockRM to validate generated
> configs as much as we could.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
