[
https://issues.apache.org/jira/browse/YARN-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046785#comment-17046785
]
Bibin Chundatt commented on YARN-6924:
--------------------------------------
[~youchen]
Over all the patch looks good..
Minor nits :
* Annotation and the method signature to be in different lines
* Same applies for the variables too in AMRMProxyMetrics.
* Since the testcase are in same package the visibility for get methods could
be package private.
> Metrics for Federation AMRMProxy
> --------------------------------
>
> Key: YARN-6924
> URL: https://issues.apache.org/jira/browse/YARN-6924
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Giovanni Matteo Fumarola
> Assignee: Young Chen
> Priority: Major
> Attachments: YARN-6924.01.patch, YARN-6924.01.patch,
> YARN-6924.02.patch, YARN-6924.02.patch, YARN-6924.03.patch, YARN-6924.04.patch
>
>
> This JIRA proposes addition of metrics for Federation AMRMProxy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
