[
https://issues.apache.org/jira/browse/YARN-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056073#comment-17056073
]
Szilard Nemeth commented on YARN-9354:
--------------------------------------
Thanks [~gandras] for working on this patch.
Latest patch LGTM, committed to trunk.
Thanks [~pbacsko] for the review.
Could you please verify how complex it is to backport this patch to branch-3.2?
Thanks.
> TestUtils#createResource calls should be replaced with
> ResourceTypesTestHelper#newResource
> ------------------------------------------------------------------------------------------
>
> Key: YARN-9354
> URL: https://issues.apache.org/jira/browse/YARN-9354
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Andras Gyori
> Priority: Trivial
> Labels: newbie, newbie++
> Attachments: YARN-9354.001.patch, YARN-9354.002.patch,
> YARN-9354.003.patch, YARN-9354.004.patch
>
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestUtils#createResource
> has not identical, but very similar implementation to
> org.apache.hadoop.yarn.resourcetypes.ResourceTypesTestHelper#newResource.
> Since these 2 methods are doing the same essentially and
> ResourceTypesTestHelper is newer and used more, TestUtils#createResource
> should be replaced with ResourceTypesTestHelper#newResource with all
> occurrence.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
