[
https://issues.apache.org/jira/browse/YARN-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056066#comment-17056066
]
Szilard Nemeth edited comment on YARN-10002 at 3/10/20, 3:47 PM:
-----------------------------------------------------------------
Hi [~bteke],
Thanks for working on this patch.
Next time, please do not touch the import order (I suppose it was automatically
done by your IDE) as it is unnecessary change for the patch and could
complicate backports, example in TestZKConfigurationStore.
Anyway, you did a very good job with this refactor, latest patch LGTM,
committed to trunk.
Thanks [~adam.antal] for the review.
[~bteke]: Please validate how complex this to be backported to branch-3.2 and
do the backport if it's possible.
Thanks
was (Author: snemeth):
Hi [~bteke],
Thanks for working on this patch.
Next time, please do not touch the import order (I suppose it was automatically
done by your IDE) as it is unnecessary change for the patch and could
complicate backports, example in TestZKConfigurationStore.
Anyway, you did a very good job with this refactor, latest patch LGTM,
committed to trunk.
Please validate how complex this to be backported to branch-3.2 and do the
backport if it's possible.
Thanks
> Code cleanup and improvements in ConfigurationStoreBaseTest
> -----------------------------------------------------------
>
> Key: YARN-10002
> URL: https://issues.apache.org/jira/browse/YARN-10002
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Benjamin Teke
> Priority: Minor
> Attachments: YARN-10002.001.patch, YARN-10002.002.patch,
> YARN-10002.003.patch, YARN-10002.004.patch, YARN-10002.005.patch,
> YARN-10002.006.patch
>
>
> * Some protected fields could be package-private
> * Could add a helper method that prepares a simple LogMutation with 1, 2 or 3
> updates (Key + value) as this pattern is used extensively in subclasses
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
