> On 10 Jan 2019, at 19:43, Viktor Ashirov <vashi...@redhat.com> wrote:
> 
> On Thu, Jan 10, 2019 at 8:03 AM William Brown <will...@blackhats.net.au> 
> wrote:
>> 
>> Hey there,
>> 
>> I think we are missing a large suite of tests from: src/lib389/lib389/tests
>> 
>> Should we move these into the suites? Or should we add this path to the CI?
> We wanted to decouple some tests from lib389 tests directory and move
> them under dirsrvtests.
> There is a ticket open for this separation:
> https://pagure.io/389-ds-base/issue/50023
> One of the issues was lib389.topologies usage. It shouldn't be shipped
> and ideally should be converted to conftest.py fixtures for
> dirsrvtests. Lib389 tests that use topologies should also be moved to
> dirsrvtests. I want to leave only unit tests and run them with tox,
> but I hit problems with venv (PR#50085) and selinux (you fixed this in
> PR#50124). So once this is fixed, I will move the tests and include
> them in nightlies.

This sounds great!

Just remember there are tests in lib389 that have a topology that is different 
- and ideally should be renamed. This is the backend-less topology I think.

But it would be great to have these tested, I noticed some were broken 
yesterday :( 

Thanks, 

>> 
>> 
>> 
>>> On 10 Jan 2019, at 13:10, vashi...@redhat.com wrote:
>>> 
>>> https://fedorapeople.org/groups/389ds/ci/nightly/2019/01/10/report-389-ds-base-1.4.0.20-20190110git50e290d.fc29.x86_64.html
>>> _______________________________________________
>>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>>> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
>>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>>> List Archives: 
>>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
>> 
>> --
>> Sincerely,
>> 
>> William
>> _______________________________________________
>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives: 
>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> 
> 
> 
> -- 
> Viktor
> _______________________________________________
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

--
Sincerely,

William
_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

Reply via email to