To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=70166
User sb changed the following:
What |Old value |New value
================================================================================
Assigned to|sb |kendy
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Aug 8 11:51:16 +0000
2007 -------
- sal/inc/osl/module.h:
-- osl_loadModuleAscii does not only differ from osl_loadModule in that it
receives an ASCII string instead of a Unicode one, but also in that it receives
a system path instead of a URL. That needs to be made more explicit (function
name, parameter name, documentation).
-- An appropriate @since tag is missing from the documentation of
osl_loadModuleAscii.
- sal/osl/w32/module.c:
-- hro, please comment on the Windows-version of osl_loadModuleAscii.
-- (void) nRtldMode; /* avoid warnings */ has to be moved after the local
variable definitions to be valid C89.
- sal/textenc/makefile.mk:
-- The duplication of SAL_COMMON_OBJFILES in sal and sal_textenc is bad.
-- For the URE-internal sal_textenc lib no UDK_MAJOR is needed (e.g., just
sal_textenc.so on Unix/ELF and sal_textenc.dll on Windows), so the
CDEFS+=-DPLUGIN_NAME stuff is not necessary and the STRING(PLUGIN_NAME) stuff in
textenc.cxx can be simplified.
- sal/textenc/tables.cxx:
-- Is a verbatim copy of sal/textenc/textenc.cxx:1.6, right? Wouldn't it be
better to keep this file named textenc.cxx as part of sal_textenc and instead
create a new file for sal?
-- The data for those textencodings that are handled directly by sal is now
doubled in sal and sal_textenc.
- sal/textenc/textenc.cxx:
-- aImpl8090SameToUniTab etc. is now doubled in textenc.cxx and tables.cxx.
-- Tabs instead of spaces.
-- Use rtl/instance.hxx to initialize pTables.
-- On CWS sb71 I found out that osl_loadModule with a plain filename is a bad
thing, so introduced osl_loadModuleRelative (see
<http://wiki.services.openoffice.org/wiki/ODF_Toolkit/Efforts/OOo_without_URE>).
That means that this use of osl_loadModuleAscii with a plain filename would
also need to be changed.
-- No C-style casts in C++ code, please.
-- The fprintf error handling is not acceptable. (std::abort instead?)
- sal/util/sal.map:
-- osl_loadModuleAscii would go into a OOo 2.4 section.
- sal/util/saltextenc.map:
-- It is somewhat unfortunate that a symbol starting "Impl_" is exported, as
that is traditionally used to denote non-exported symbols.
- The new URE-internal lib sal_textenc would also have to be added to
ure/source/README and scp2/source/ure/ure.scp.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
