On Fri Apr 10, 2026 at 3:32 AM EDT, Dan Carpenter wrote:
1057 amdgpu_connector->use_digital =
--> 1058
drm_edid_is_digital(amdgpu_connector->edid);
^^^^^^^^^^^^^^^^^^^^^^
Use after free.
Lovely. I was wondering if that Claude review[1] was accurate. I also
asked in IRC if it was something to be considered about but I didn't
get a response[2]. I'll be more pressing next time, sorry.
This morning I'm unable to test, but I think reverting the commit that
removed amdgpu_connector_free_edid[3] should fix it.
What do you think?
Thanks again for the report.
[1]:
https://lore.gitlab.freedesktop.org/drm-ai-reviews/[email protected]/
[2]:
https://people.freedesktop.org/~cbrill/dri-log/?channel=radeon&highlight_names=&date=2026-03-17&show_html=true
[3]:
https://gitlab.freedesktop.org/agd5f/linux/-/commit/289479173fb538f3ec7aac5206f49e39367ee75c
-Josh
