I've been looking into all the ioctls used by the android framework,
and i discovered some irregular definitions in the kernel headers.

In msm_audio.h:
there is the following definition
#define SND_SET_DEVICE _IOW(SND_IOCTL_MAGIC, 2, struct msm_device_config *)

struct msm_device_config is actually not defined in the header, but
instead struct msm_snd_device_config is.
The rest of the ioctls make use of structures named msm_snd_..., which
might mean that this was a typo.

In android_pmem.h:
ioctls PMEM_GET_PHYS & PMEM_GET_SIZE are defined with _IOW, while they
are reading from kernel space.
I haven't looked at the rest of the ioctls if they're defined properly.

In msm_adsp.h:
similarly ioctl ADSP_IOCTL_WRITE_COMMAND is declared using _IOR, while
it is actually writing.

Are these bugs, or is something else going on.

Cheers,
George

--~--~---------~--~----~------------~-------~--~----~
unsubscribe: android-kernel+unsubscr...@googlegroups.com
website: http://groups.google.com/group/android-kernel
-~----------~----~----~----~------~----~------~--~---

Reply via email to