When development of the zfs module started there was no possibility to set 
check_invalid_arguments=False in the argspec and i don't think complex args 
were available either so ALL zfs properties ended up being an ansible 
module option. This is bad because options have different names and 
settings on different OS'es and zpool versions.

I have a reworked version of the zfs module here: 
https://github.com/johanwiren/ansible-modules-extras/commit/e549d967233879981d3639c83d757bafd8274265?diff=unified

My proposal is to skip option checking in the ansible module and pass on 
all options to the zfs command to set/update the properties. This probably 
breaks some guidelines about options being documented, but I don't see a 
better way of doing it.

Comments and thoughts about that?

I did not create a PR for it since I read that module owners get their PRs 
merged automatically, which is not intended in this case :)

/Johan

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/c63dafac-0c20-42d9-bf79-af72c98b6a30%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to