----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4038/#review13606 -----------------------------------------------------------
Ship it! LGTM. /asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/4038/#comment24120> lstrip usage is wrong. /asterisk/trunk/runtests.py <https://reviewboard.asterisk.org/r/4038/#comment24119> lstrip() does not do what it looks like. I thought someone fixed this everywhere already? - wdoekes On Oct. 29, 2014, 9:47 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4038/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 9:47 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24379 > https://issues.asterisk.org/jira/browse/ASTERISK-24379 > > > Repository: testsuite > > > Description > ------- > > This causes any test that leaks references to fail if REF_DEBUG is enabled. > > Additionally run-local is modified to allow REF_DEBUG to be enabled through > setup: > MENUSELECT_OPTIONS='--enable REF_DEBUG' ./run-local setup > > Note if this option is used with Asterisk 1.8 all tests will fail due to > manager.c leaking the sessions container. > > > Diffs > ----- > > /asterisk/trunk/runtests.py 5803 > /asterisk/trunk/run-local 5803 > /asterisk/trunk/contrib/scripts/refleaks-summary PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4038/diff/ > > > Testing > ------- > > Ran against tests/channels/SIP/route on Asterisk 11 with and without r4037 > applied. Test fails without, passes with. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev