2007/10/29, Nick Kossifidis <[EMAIL PROTECTED]>:
> 2007/10/29, Frank de Lange <[EMAIL PROTECTED]>:
> > On Mon, Oct 29, 2007 at 01:05:23PM +0100, Frank de Lange wrote:
> > > To reply to my own question, yes -22 is -EINVAL and it seems to be
> > > generated when the driver tries to get the rate table for the device:
> > >
> > > [ 2027.007789] ath5k_hw_reset:547
> > > [ 2027.007796] ath5k_hw_nic_wakeup:368
> > > [ 2027.007801] ath5k_hw_set_power:1085
> > > [ 2027.007808] ath5k_hw_nic_reset:1038
> > > [ 2027.009591] ath5k_hw_get_rate_table:494
> > > [ 2027.009597] unable to reset hardware: -22
> > >
> > > (I commented out the trace on intr_pending as that just fills up the log
> > > with needless garbage)
> > >
> > > This is a bg device... Is it trying to get rates for 802.11a as well (in 
> > > hw.c:697)?
> >
> > Confirmed. Tell it to get a rate table for MODE_IEEE80211G instead of
> > one of the MODE_ATHEROS_TURBO/G modes and it does not return EINVAL. It
> > doesn't work either, unfortunately... yet...
> >
> > Cheers//Frank
> >
>
> Obvious bug, i wonder how it ended up there...
>
> This was the original code from madwifi-old-openhal...
> rt = ath5k_hw_get_rate_table(hal,
>  channel->channel_flags & CHANNEL_TURBO ?
>  AR5K_MODE_TURBO : AR5K_MODE_XR);
>
> AR5K_MODE_XR fits for a/g/xr modes that use OFDM
>
> and it turned out...
>
> rt = ath5k_hw_get_rate_table(hal,
>  channel->val & CHANNEL_TURBO ?
>  MODE_ATHEROS_TURBO :
>  MODE_ATHEROS_TURBOG);
>
> anyway it's not there, i'm comparing regdumps from a bg card that were
> submited here some time ago with the code. I hope i'll find out what's
> up...
>
> --
> GPG ID: 0xD21DB2DB
> As you read this post global entropy rises. Have Fun ;-)
> Nick
>

O.K. lets start with this (line 639 after my patches):

In ath5k_hw_reset we do this...

/* PHY access enable */
ath5k_hw_reg_write(ah, AR5K_PHY_SHIFT_5GHZ, AR5K_PHY(0));

try changing AR5K_PHY_SHIFT_5GHZ to AR5K_PHY_SHIFT_2GHZ and see what
happens (i haven't checked out regdumps yet, after the above bug i'm
reviewing the code again).

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to