On Tue, Jul 27, 2010 at 12:17:13AM +0300, Maxim Levitsky wrote:

> However, it is possible, (and that what I asked you) that some ath5k
> devices aren't 'pre 1.1 pcie devices' so linux won't disable ASPM L0s
> for them.
> So indeed for 'good feeling' it is ok to disable L0s from ath5k
> explicitly, but most of the time (or always) it will be no-op.
> 
> In *addition* to that, since you said that ASPM L1 *does* work, and is
> enabled by BIOS, but linux disables it, that it might be worthy to
> enable it again from ath5k driver explicitly.
> As long as wireless works I don't really care if this done or not.

This may need to be done on a chip by chip basis. Take a look at 
http://www.atheros.cz/inffile.php?inf=68&bit=32&atheros=AR5002G&system=4 
and some of the other inf files on that site to see which devices 
provide the PciASPMOptIn flag - those should support ASPM states even if 
they're pre-1.1 devices.

-- 
Matthew Garrett | mj...@srcf.ucam.org
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to