On Fri, 2010-08-13 at 11:30 -0700, Luis R. Rodriguez wrote: > On Fri, Aug 13, 2010 at 8:40 AM, Maxim Levitsky <maximlevit...@gmail.com> > wrote: > > On Fri, 2010-08-13 at 07:51 -0700, Luis R. Rodriguez wrote: > >> On Fri, Aug 13, 2010 at 07:21:28AM -0700, Roman Yepishev wrote: > >> > On Thu, 2010-08-05 at 11:19 -0700, Luis R. Rodriguez wrote: > >> > > On Thu, Aug 5, 2010 at 8:33 AM, Maxim Levitsky > >> > > <maximlevit...@gmail.com> wrote: > >> > > > Atheros PCIe wireless cards handled by ath5k, don't work well with > >> > > > PCIe > >> > > > ASPM L0s enabled. > >> > > > > >> > > [...] > >> > > Acked-by: Luis R. Rodriguez <lrodrig...@atheros.com> > >> > > > >> > > Please repost to linux-wireless and address Linville. Also Cc > >> > > sta...@kernel.org on the commit log entry. > >> > > >> > Has this been forwarded to linux-wireless list? I can't seem to find the > >> > changes in linville/wireless-testing.git. > >> > > >> > I have been testing this patch for a week and must say that I had no > >> > single corrupted download since then. > >> > I have also re-posted the link to this thread and the patch to > >> > LP:369005[0]. > >> > > >> > Thank you very much for the fix! > >> > > >> > [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/369005 > >> > >> I don't see it merged yet.. I'm going to resend now but change > >> the commit log a bit. > > > > Note that this patch is mostly a red herriring, because it is unlikely > > that there are ath5k devices without 'Legacy' bit set. > > The CONFIG_PCIE_ASPM alone is enough to fix the problem. > > Thats why I didn't paid much attention to this patch. > > Not all linux distributions ship with CONFIG_PCIE_ASPM, so this is > more of a stable fix which will be important for kernels below 2.6.36.
Without CONFIG_PCIE_ASPM, this patch does exactly nothing. The original patch from Jussi Kivilinna, did contain some direct register poking when CONFIG_PCIE_ASPM is disabled. However we agreed that it isn't worth to do that but rather just enable the CONFIG_PCIE_ASPM always. Best regards, Maxim Levitsky _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
