> > When ath5k doesn't get retry limits from above it uses the following > > defaults on dcu. > > For now i don't think we use local->hw.conf.short_frame_max_tx_count > > for that so the > > default is ah_limit_tx_retries (AR5K_INIT_TX_RETRY) but seems it's > > wrong and we should > > fix it... > > > > /* Tx retry limits */ > > #define AR5K_INIT_SH_RETRY 10 > > #define AR5K_INIT_LG_RETRY AR5K_INIT_SH_RETRY > > /* For station mode */ > > #define AR5K_INIT_SSH_RETRY 32 > > #define AR5K_INIT_SLG_RETRY AR5K_INIT_SSH_RETRY > > #define AR5K_INIT_TX_RETRY 10
I just sent a patch cleaning up this mess. Could you please check it? Unfortunately i didn't find way to really test re-transmissions, yet. Jonathan, could you give it a try in your test setup with my patch, and play with the numbers (just hardcode them in ath5k_hw_set_tx_retry_limits) to see if they actually have an effect? As noted in my patch, this does not change the high number of retries we get from the rate control. That's a separate issue. bruno _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
