Oops, the patch was malformed by my email client, resending now.
2011/3/26 Alberto Ortega <albe...@pentbox.net>:
> Greetings,
>
> this patch fixes some coding style errors (warnings and errors).
>
> Signed-off-by: Alberto Ortega Llamas <albe...@pentbox.net>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/base.c
> b/drivers/net/wireless/ath/ath5k/base.c
> index 4d7f21e..3efdfcc 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -333,7 +333,8 @@ ath5k_setup_rate_idx(struct ath5k_softc *sc,
> struct ieee80211_supported_band *b)
> for (i = 0; i < b->n_bitrates; i++) {
> sc->rate_idx[b->band][b->bitrates[i].hw_value] = i;
> if (b->bitrates[i].hw_value_short)
> - sc->rate_idx[b->band][b->bitrates[i].hw_value_short]
> = i;
> + sc->rate_idx[b->band][b->bitrates[i].hw_value_short]
> + = i;
> }
> }
>
> @@ -1262,12 +1263,10 @@ static int ath5k_common_padpos(struct sk_buff *skb)
> __le16 frame_control = hdr->frame_control;
> int padpos = 24;
>
> - if (ieee80211_has_a4(frame_control)) {
> + if (ieee80211_has_a4(frame_control))
> padpos += ETH_ALEN;
> - }
> - if (ieee80211_is_data_qos(frame_control)) {
> + if (ieee80211_is_data_qos(frame_control))
> padpos += IEEE80211_QOS_CTL_LEN;
> - }
>
> return padpos;
> }
> @@ -1281,7 +1280,7 @@ static int ath5k_add_padding(struct sk_buff *skb)
> int padpos = ath5k_common_padpos(skb);
> int padsize = padpos & 3;
>
> - if (padsize && skb->len>padpos) {
> + if (padsize && skb->len > padpos) {
>
> if (skb_headroom(skb) < padsize)
> return -1;
> @@ -1312,7 +1311,7 @@ static int ath5k_remove_padding(struct sk_buff *skb)
> int padpos = ath5k_common_padpos(skb);
> int padsize = padpos & 3;
>
> - if (padsize && skb->len>=padpos+padsize) {
> + if (padsize && skb->len >= padpos+padsize) {
> memmove(skb->data + padsize, skb->data, padpos);
> skb_pull(skb, padsize);
> return padsize;
> @@ -1687,7 +1686,7 @@ ath5k_tasklet_tx(unsigned long data)
> int i;
> struct ath5k_softc *sc = (void *)data;
>
> - for (i=0; i < AR5K_NUM_TX_QUEUES; i++)
> + for (i = 0; i < AR5K_NUM_TX_QUEUES; i++)
> if (sc->txqs[i].setup && (sc->ah->ah_txq_isr & BIT(i)))
> ath5k_tx_processq(sc, &sc->txqs[i]);
> }
> @@ -1886,7 +1885,8 @@ ath5k_beacon_send(struct ath5k_softc *sc)
> * are still pending on the queue.
> */
> if (unlikely(ath5k_hw_stop_beacon_queue(ah, sc->bhalq))) {
> - ATH5K_WARN(sc, "beacon queue %u didn't start/stop ?\n",
> sc->bhalq);
> + ATH5K_WARN(sc, "beacon queue %u didn't start/stop ?\n",
> + sc->bhalq);
> /* NB: hw still stops DMA, so proceed */
> }
>
> @@ -1951,7 +1951,7 @@ ath5k_beacon_update_timers(struct ath5k_softc
> *sc, u64 bc_tsf)
> hw_tsf = ath5k_hw_get_tsf64(ah);
> hw_tu = TSF_TO_TU(hw_tsf);
>
> -#define FUDGE AR5K_TUNE_SW_BEACON_RESP + 3
> +#define FUDGE (AR5K_TUNE_SW_BEACON_RESP + 3)
> /* We use FUDGE to make sure the next TBTT is ahead of the current TU.
> * Since we later substract AR5K_TUNE_SW_BEACON_RESP (10) in the timer
> * configuration we need to make sure it is bigger than that. */
> @@ -2159,13 +2159,11 @@ ath5k_intr(int irq, void *dev_id)
> ATH5K_DBG(sc, ATH5K_DEBUG_RESET,
> "rx overrun, resetting\n");
> ieee80211_queue_work(sc->hw, &sc->reset_work);
> - }
> - else
> + } else
> tasklet_schedule(&sc->rxtq);
> } else {
> - if (status & AR5K_INT_SWBA) {
> + if (status & AR5K_INT_SWBA)
> tasklet_hi_schedule(&sc->beacontq);
> - }
> if (status & AR5K_INT_RXEOL) {
> /*
> * NB: the hardware should re-read the link when
> @@ -2183,9 +2181,8 @@ ath5k_intr(int irq, void *dev_id)
> if (status & (AR5K_INT_TXOK | AR5K_INT_TXDESC
> | AR5K_INT_TXERR | AR5K_INT_TXEOL))
> tasklet_schedule(&sc->txtq);
> - if (status & AR5K_INT_BMISS) {
> + if (status & AR5K_INT_BMISS)
> /* TODO */
> - }
> if (status & AR5K_INT_MIB) {
> sc->stats.mib_intr++;
> ath5k_hw_update_mib_counters(ah);
>
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
