THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#1211 - Support touchscreen
User who did this - Lingzhu Xiang (xlz)
----------
Yes I intended to create a proper patch after a proper solution is confirmed.
ev->detail = 0 means no button by xcb docs. The 0 could be coded as
XCB_BUTTON_INDEX_ANY ("Any of the following (or none)") but it doesn't make
more sense either. I did test it with lua logging code in
awful.mouse.client.move. Let me describe the code flow to make sure: 1) when
button 1 is pressed, the button callback client.move installs the mousegrabber
callback and grabs the mouse but not calls the callback; 2) when more motion or
button events come in, the mousegrabber callback is called; 3) when the
mousegrabber callback gets an event of no button it returns false, the the
mouse grab is stopped.
You did point out an issue with the current approach: if the user grabs mouse
with button 1 pressed and then release button 2, the grab is stopped. I can't
imagine a valid use case for such behavior, but I'm willing to discuss about
how to patch this.
So if we want to make sure the grab is stopped only on the right button
release, then we have to keep track of which button is pressed when the mouse
is grabbed. Keeping track of states complicates things. See if you like it.
----------
One or more files have been attached.
More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1211#comment3812
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
