Hi,

On 02.03.2014 18:32, Massimiliano Brocchini wrote:
> i like to keep only correct command in my history entries and I didn't want
> to edit cache files anymore.
> 
> Attached patch adds CTRL+DELETE shortcut to prompt.lua to delete visible
> command from history.

I almost like the patch (except for the missing line breaks in the commit
message and the new call to history_save() for which I can't find a reasonable
explanation; yeah, we could have changed the history when Esc is pressed, but
still this code seems weird...).

Anyway, git doesn't like your patch. I end up with this commit message, could
you... dunno, send me the file differently?

commit 42ec82ce564ab5e867b5560f5b491b8ed8d4b50b
Author: Massimiliano Brocchini <massimiliano.brocch...@gmail.com>
Date:   Sun Mar 2 18:32:21 2014 +0100

    prompt.lua added possibility to delete history entries

    --001a1135e0f4e680b904f3a30e26
    Content-Type: text/plain; charset=ISO-8859-1

    Hi all,

    i like to keep only correct command in my history entries and I didn't want
    to edit cache files anymore.

    Attached patch adds CTRL+DELETE shortcut to prompt.lua to delete visible
    command from history.

    If this gets accepted and committed, you are invited to remind me to
    document all keyboard shortcuts and their behaviour in a wiki page once a
    new release will be out.

    Ciao,
    Massi

    <div dir="ltr">Hi all,<div><br></div><div style>i like to keep only correct
command in my history entries and I didn&#39;t want to edit cache files
anymore.</div><div style><br></div><di
v style>Attached patch adds CTRL+DELETE shortcut to prompt.lua to delete visible
command from history.</div>

    <div style><br></div><div style>If this gets accepted and committed, you are
invited to remind me to document all keyboard shortcuts and their behaviour in a
wiki page once a new release will be out.</div><div style><br>
    </div>
    <div style>Ciao,</div><div style>Massi</div></div>

    From 434d6845c41c7c833f3d4fd984637eb2ef933d19 Mon Sep 17 00:00:00 2001
    From: Massimiliano Brocchini <massimiliano.brocch...@gmail.com>
    Date: Sun, 2 Mar 2014 18:34:22 +0100
    Subject: [PATCH 3/3] prompt: CTRL+DELETE deletes history entries

    Pressing CTRL+DELETE removes the visible history entry, if any, then moves
to the next history entry (like pressing DOWN would do). If the last history
entry is removed the previous one is shown in the prompt (like pressing UP would
do). CTRL+DELETE works on history entries only: i.e. it has no effect on a
command entered but not executed yet. To implement above behaviour I added
saving history table to file on Escape key press.

    Signed-off-by: Massimiliano Brocchini <massimiliano.brocch...@gmail.com>

> If this gets accepted and committed, you are invited to remind me to
> document all keyboard shortcuts and their behaviour in a wiki page once a
> new release will be out.

Feel free to add that to the ldoc comments in the source. :-)

Uli
-- 
Q: Because it reverses the logical flow of conversation.
A: Why is putting a reply at the top of the message frowned upon?

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Reply via email to