THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#1218 - Scrolling layout User who did this - Uli Schlachter (psychon) ---------- First some formal things: Please send patches via git (commit your change to git (with good commit message), git format-patch origin/master.. gives you a file that you can submit). Please use the license header that every other lua file uses, too (but the copyright is yours). - The :to_end() function only works if self._max_offset is up to date and this only happens in the :draw() method. So :to_end() only works a random time after the widget was created and added to some wibox. I guess you need some function for calculating _max_offset, but I don't know how such a thing could look like. - The widget can only be shown in a single position. If I add it to more than one place, the smaller of the two will interfere with the other location (I am not completely sure what exactly will happen). - Functions should use luadoc. (Look at e.g. lib/awful/util.lua for some examples. Your code misses some @param and @return annotations) - I don't see why a scroll layout without any widgets should get handled specially in :fit(). - "-- In first time we just calculate max offset. Now we can draw widgets." <- This just doesn't work. This code heavily assumes that the widget will always be drawn with the same size (unless widget::updated occurs). However, the size could change because we have e.g. this widget next to a textclock and the textclock's width is "unstable" (some letters are smaller than others) - :draw() scares me. I guess I have enough complaints for now... ---------- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1218#comment3844 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
