THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#1181 - Clients resize lag
User who did this - Daniel Hahler (blueyed)

----------
I am sorry, this lag was caused by some stupid call to awful.client.moveresize 
in a custom arrange signal handler (based on a snippet I found early when 
starting to use awesomeWM):

-- {{{ Arrange signal handler
for s = 1, screen.count() do screen[s]:connect_signal("arrange", function ()
        local clients = awful.client.visible(s)
        local layout = awful.layout.getname(awful.layout.get(s))

        if #clients > 0 then -- Fine grained borders and floaters control

                for _, c in pairs(clients) do -- Floaters always have borders
                        -- No borders with only one humanly visible client
                        -- Changed: "max" layout can have floating clients! 
(see "floatingterm")
                        -- bdebug({c, c.maximized_vertical, 
c.maximized_horizontal}, "arrange_no_border")
                        if c.maximized_vertical and c.maximized_horizontal then
                                -- NOTE: also handled in focus, but that is not 
covers maximizing from a tiled state (when the client had focus).
                                c.border_width = 0
                        elseif awful.client.floating.get(c) or layout == 
"floating" then
                                c.border_width = beautiful.border_width
                        elseif layout == "max" or layout == "fullscreen" then
                                c.border_width = 0
                        else
                                local tiled = awful.client.tiled(c.screen)
                                if #tiled == 1 then -- and c == tiled[1] then
                                        -- gears.debug.assert(tiled[1] == c, 
"border_width: only c should come here")
                                        tiled[1].border_width = 0
                                        -- if layout ~= "max" and layout ~= 
"fullscreen" then
==>                     awful.client.moveresize(0, 0, 2, 0, tiled[1])
                                        -- end
                                else
                                        c.border_width = beautiful.border_width
                                end
                        end
                end
        end
end)
end

The moveresize isn't required here at all.

btw: is there a better signal, which would not get emitted while clients are 
still being moved?
Or would I have to test for the state of the mouse (buttons), if I want to skip 
certain actions/checks?
----------

More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1181#comment3955

You are receiving this message because you have requested it from the Flyspray 
bugtracking system.  If you did not expect this message or don't want to 
receive mails in future, you can change your notification settings at the URL 
shown above.

--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Reply via email to