Hello Chris, Thanks for your patch. Although I did not directly apply it, I basically took the fact that you discovered that regexes are slow, and removed them all from the restore code. In a number of cases, what I implemented was the same as what you did, since it is rather obvious, but I also eliminated the regexes associated with testing for a win32 drive and replaced them by a subroutine that does normal character indexing.
Many thanks for pointing this out. The updates *should* be in version 2.2.5, to come out soon, unless I find some real problem. Best regards, Kern On Sunday 23 September 2007 15:25, Chris Howells wrote: > Chris Howells wrote: > > Hi, > > > > bat is rather slow for me with loading very large backups into the > > restore window. I therefore did some profiling of it using KCacheGrind > > (which uses callgrind, part of valgrind). > > Hi, > > Attached is an updated patch which removes more QRegExp. The profiling > shows that calling QProgressBar::setText() is also *fairly* expensive; > previously bat seemed to be doing this for every single file, which was > quite bad. bat now only updated the progress bar for every 1000 items. > You won't notice any difference in terms of UI, other than it will be > quicker to load a job. Also I've tried to stick exactly to the existing > coding style which I failed a bit in the first patch :) > > With this patch loading a 450GB backup (2.7million files) into bat now > takes 280 seconds for me, rather than 466 seconds. That's nearly a 40% > improvement. > > If anybody can verify that the patch doesn't cause any regressions, and > also provides a similar performance boost, I'd be grateful if it could > go into SVN :) > > The profiling stats suggest that there is still some more optimisation > that can be done, but these were the easy pickings. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
