On Thursday 17 May 2007 07:26:48 pm Chris Frey wrote: > On Wed, May 16, 2007 at 05:58:11AM -0600, Brian Edginton wrote: > > Here is a patch to add FreeBusy and Class information to Calendar and add > > some of the clear() I missed in Contact. > > Thanks very much for your work on this. Some comments: > > + /// > > + /// Free Busy Flag > > + /// > > + /// This lists the available settings found in the device. > > + /// This list is based on information from MS Outlook 2007 > > + /// (Free ==0 and Busy == 2) > > + /// This is FBTYPE in RFC2445 and is defined as > > + /// FREE, BUSY, BUSY-UNAVAILABLE and BUSY-TENTATIVE > > + /// > > + > > + char FreeBusyFlag; > > I hesitate adding a field without at least some enums to define > what values are valid.
Sounds good. I struggled with this and probably moved them in and out of the code a half dozen times. I think what finally made me pull them was the fact that the ordering I was seeing didn't seem to follow my interpretation of RFC2445. I can put them back in, no problem. Ditto with the Class information. I had also put logic in to detect out of range values in record.cc. I'll put it back in (always go with your first instinct) > > > > Either that, or we need some member functions, such as SetBusy(), > SetFree(), etc. I think the enum will do for now. > > > + /// This list is based on information from MS Outlook 2007 > > I'm curious why Outlook is being used as a reference for the Blackberry. > Maybe I'm just dense. :-) I just don't understand why it's in the > comments. I'm using Outlook to sync the BB to, it's more of a 'note to self' I'll avoid it in the future. > > Btw, Barry uses tabs instead of spaces... if you could match your > patches to the existing coding style, that would be much appreciated. :-) np -edge
pgpGQFaBzRZga.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Barry-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/barry-devel
