On Wed, 5 Jun 2024 13:21:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 113 commits: >> >> - Mark some tests with requiring packaged modules >> - Correctly set packaged modules default >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Fix new line in jlink.properties >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - Simplify JLINK_JDK_EXTRA_OPTS var handling >> - Only add runtime track files for linkable runtimes >> - Generate the runtime image link diff at jlink time >> >> But only do that once the plugin-pipeline has run. The generation is >> enabled with the hidden option '--generate-linkable-runtime' and >> the resource pools available at jlink time are being used to generate >> the diff. >> - Merge branch 'master' into jdk-8311302-jmodless-link >> - ... and 103 more: https://git.openjdk.org/jdk/compare/64bbae75...0eb1e48d > >> [5fef297](https://github.com/openjdk/jdk/commit/5fef297ba999963d60452f098193d2cba33a941b) >> implements this. > > I think it was surprising that --enable-runtime-link-image still included the > packaged modules so thanks for taking the feedback on this point. Thanks for the review, @AlanBateman! Updates pushed. > test/jdk/tools/lib/tests/JImageHelper.java line 38: > >> 36: * JDK Modular image iterator >> 37: */ >> 38: public class JImageHelper { > > This is only usable in tests that use `@modules` to open > jdk.internal.jimage.*. It might be better co-locate this with the jlink > tests for now. It may be that we do have test infra structure for jimage in > the future but starting out with the supporting test lib in the jlink test > tree should be okay. Sure. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2150589379 PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1628156069
