simon_tatham marked an inline comment as done.
simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2399
+  foreach pred_int = [int_arm_mve_vshll_imm_predicated] in
+  foreach imm = [inst_imm.immediateType] in {
+
----------------
MarkMurrayARM wrote:
> *OUCH* 6 deep :-)
Yes, but each of those loops is over a length-1 list, so it's not actually 
taking any time!

This is just the kind of thing I'd have preferred to do using an actual 'define 
local variable' command. But Tablegen doesn't have one. If D74107 is approved 
then I'll be able to convert all of these into `defvar`, along with many other 
uses of this singleton-foreach idiom.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71458/new/

https://reviews.llvm.org/D71458



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to