erichkeane added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2048 LValue RecordLV, CharUnits Align, - llvm::FunctionCallee Func, int Lvl) { + bool dumpTypeName, llvm::FunctionCallee Func, + int Lvl) { ---------------- yihanaa wrote: > erichkeane wrote: > > Not a fan of bool parameters, they make calls harder to read. > I can add comments for this parameter or this function, what do you think, or > do you have a better idea? I would like to improve it. I prefer using an 'enum' for these sorts of things, we do that elsewhere. It seems that what you ACTUALLY care about here is whether this is a 'top level', and thus has a FieldName to print, right? So you actually want to dumpFieldName? Or am I still misunderstanding something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits